Opened 12 years ago Closed 12 years ago #687 closed defect (fixed)Missing clip in 8.6.5 Picture construction process prior to in-loop filter process?
Description
In section 8.6.5 on "Picture construction process prior to in-loop filter process", either Inter or Intra predicted samples are added to residual samples to form reconstructed samples.
This process does not clip the reconstructed samples to be in the range 0 to (1<<BitDepth)-1. I can't see any subsequent stage which would clip the samples (where in-loop filter may not modify the samples) to ensure the reconstructed frames are clipped to the correct precision.
In the HM software, in TDecCu.cpp, for Inter data the function 'xReconInter' uses 'addClip' function, and for Intra data 'xReconIntraQT' calls 'xIntraLumaRecQT', which calls 'xIntraRecLumaBlk', which clips the luma samples (there is a similar function for chroma).
Unless I've a missed a clip operation somewhere else in the text, I beleive section 8.6.5 should be modified as follows;-
Depending on the colour component cIdx, the following assignments are made.
The (nS)x(nS) block of the reconstructed sample array recSamples at location ( xB, yB ) is derived as follows.
Change History (7)comment:1 Changed 12 years ago by DefaultCC Plugin
comment:2 Changed 12 years ago by bbrosscomment:3 Changed 12 years ago by bbross
Ticket #836 has been marked as a duplicate of this ticket. comment:4 Changed 12 years ago by bbross
comment:5 Changed 12 years ago by bbross
comment:6 Changed 12 years ago by bbross
comment:7 Changed 12 years ago by bbross
This has been fixed in JCTVC-K1003_v11. Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
Ticket #807 has been marked as a duplicate of this ticket.