Opened 8 years ago

Closed 8 years ago

#989 closed defect (fixed)

getDistPart used incorrectly for inter chroma

Reported by: karlsharman Owned by:
Priority: minor Milestone: HM-10.0
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

getDistPart has, as of HM9.2, had an extra TEXT_TYPE parameter added for chroma weighting control. A default is specified, which causes problems when not overridden:

On lines 4890, 4910, 4965, 4984, 5213, 5257 of TEncSearch.cpp, TEXT_CHROMA_U or TEXT_CHROMA_V should be passed, otherwise only the Cr weighting parameter will be used.

In addition, is the bWeighted flag still required, since this can be derived from the TextType passed in? (i.e. just checking that eText is not TEXT_LUMA)

(Identified during RExt development.)

Change History (2)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by fbossen

  • Milestone set to HM-10.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3343

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)