Opened 9 years ago

Closed 9 years ago

#988 closed enhancement (fixed)

SAO_SKIP_RIGHT macro not always used

Reported by: karlsharman Owned by:
Priority: minor Milestone: HM-10.0
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In TEncSampleAdaptiveOffset.cpp:calcSaoStatsCuOrg, lines
1058, 1106, 1142, 1189, 1241, SAO_SKIP_RIGHT macro is not used to guard against use of numSkipLineRight.

There's also a possible inconsistency with usage in calcSaoStatsCu_BeforeDblk, where numSkipLineRight is always used, independent on SAO_SKIP_RIGHT.

Is SAO_SKIP_RIGHT macro still required?

(Identified during RExt development.)

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by fbossen

  • Milestone set to HM-10.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3344

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)