Opened 9 years ago

Closed 8 years ago

#990 closed defect (fixed)

RDOQ_CHROMA_LAMBDA interaction with TComTrQuant

Reported by: karlsharman Owned by:
Priority: minor Milestone: HM-12.1
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

When RDOQ_CHROMA_LAMBDA macro is enabled, the chroma channels may have a different lambda weighting from the luma during RDOQ.

However, in TEncSlice.cpp, lines 353, 470, 574, 685, 741, the calls to setLambda use the lambda for Luminance and the lambda for Cr. This will cause reduced performance when Cr's QP offset is different from Cb's QP offset.

Should setLambda therefore take 3 lambda values - Y, Cb and Cr, and calls to selectLambda in TEncSearch pass in TEXT_CHROMA_U and TEXT_CHROMA_V instead of TEXT_CHROMA?

There's a similar issue with SAO, but the changes required are less trivial.

(Identified during RExt development.)

Attachments (1)

patch-ticket-990.txt (36.5 KB) - added by karlsharman 8 years ago.
Fix of ticket 990 - correction of lambda for luma and chroma.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 8 years ago by karlsharman

Fix of ticket 990 - correction of lambda for luma and chroma.

comment:2 Changed 8 years ago by fbossen

  • Milestone set to HM-12.1
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3632

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)