Opened 9 years ago

Closed 9 years ago

#583 closed defect (fixed)

mismatch between the WD text and the HM software on chroma deblocking

Reported by: suzukiyos Owned by: bbross
Priority: minor Milestone: D7
Component: Text Version: D7 (I1003) d4
Keywords: Cc: bbross, wjhan, jct-vc@…

Description

In HM, the deblocking filter for chroma is applied only when bS>1.
Please refer TComLoopFilter::xEdgeFilterChroma ().
However, it is not clearly defined in the text.

Possible solution (8.7.1.4.5 Filtering process for chroma block edge):
Add the following line just after "output of this process".

"This process is involved when bS is greater than 1."

Change History (2)

comment:1 Changed 9 years ago by bbross

  • Milestone set to D7

In the text it is always defined before the chroma block edge process is invoked. i.e. in

8.7.1.4.1 Vertical edge filtering process
8.7.1.4.2 Horizontal edge filtering process

as follows:

"– When bS[ xDk*2 ][ yDm*2 ] is greater than 1, the following ordered steps apply.

  1. The filtering process for chroma block edge as specified in subclause 8.7.1.4.5 is invoked with the chroma picture buffer recPictureCb, the location of the chroma coding block ( xC/2, yC/2 ), the chroma location of the block ( xDk, yDm ), a variable edgeType set equal to EDGE_HOR, and the boundary filtering strength bS[ xDk*2 ][ yDm*2 ] as inputs and the modified chroma picture buffer recPictureCb as output.
  2. The filtering process for chroma block edge as specified in subclause 8.7.1.4.5 is invoked with the chroma picture buffer recPictureCr, the location of the chroma coding block ( xC/2, yC/2 ), the chroma location of the block ( xDk, yDm ), a variable edgeType set equal to EDGE_HOR, and the boundary filtering strength bS[ xDk*2 ][ yDm*2 ] as inputs and the modified chroma picture buffer recPictureCr as output."

So the text is right but I am wondering why bS is an input parameter for

8.7.1.4.4 Filtering process for luma block edge

The only reason why this parameter would be passed is the following sentence:
"This process is invoked only when bS is not equal to 0."
But like for chroma this is assured not to happen by

"– When bS[ xDk ][ yDm ] is greater than 0, the following ordered steps apply.

  1. The decision process for luma block edge as specified in subclause 8.7.1.4.3 is invoked with the luma picture buffer recPictureL, the location of the luma coding block ( xC, yC ), the luma location of the block ( xDk, yDm ), a variable edgeType set equal to EDGE_HOR, and the boundary filtering strength bS[ xDk ][ yDm ] as inputs, the decisions dE, dEp, dEq, and the variables β, tC as outputs.
  2. The filtering process for luma block edge as specified in subclause 8.7.1.4.4 is invoked with the luma picture buffer recPictureL, the location of the luma coding block ( xC, yC ), the luma location of the block ( xDk, yDm ), a variable edgeType set equal to EDGE_HOR, the boundary filtering strength bS[ xDk ][ yDm ], the decisions dEp, dEp, dEq, and the variables β, tC as inputs and the modified luma picture buffer recPictureL as output."

My suggestion is to remove the bS input parameter and the corresponding (informative) sentence "This process is invoked only when bS is not equal to 0." from 8.7.1.4.4 Filtering process for luma block edge.

comment:2 Changed 9 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

This is fixed in JCTVC-I1003 d5 (v6).

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Woo-Jin Han(Subscriber)
  • Yoshinori Suzuki(Reporter)