Opened 9 years ago

Closed 9 years ago

#261 closed defect (fixed)

wavefrontsynchro=1 causes decoder crashes

Reported by: gordon Owned by:
Priority: minor Milestone: HM-5.1
Component: HM Version: HM-5.0
Keywords: wavefrontsynchro Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

A newly introduced CABAC context (m_cCUSigCoeffGroupSCModel) is not being saved correctly in the encoder when WaveFrontSynchro is activated in the config. This causes decoder mismatches and crashes.

Although the minimum change is just to save the context correctly in TEncSbac::xCopyContextsFrom, the attached patches change both TEncSbac::xCopyContextsFrom and TDecSbac::xCopyContextsFrom, replacing the by-name context copies with a single memcpy. This will avoid future problems like this.

Attachments (2)

TDecSbac.cpp.patch (3.6 KB) - added by gordon 9 years ago.
TEncSbac.cpp.patch (3.5 KB) - added by gordon 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf added

Changed 9 years ago by gordon

Changed 9 years ago by gordon

comment:2 Changed 9 years ago by ksuehring

  • Milestone set to HM-5.1
  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in rev 1702 (HM-5.0-dev-bugfix)

comment:3 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • gordon clare(Reporter)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)