Opened 10 years ago

Closed 9 years ago

#249 closed defect (fixed)

valgrind error in ALF decoding:

Reported by: thomasd Owned by:
Priority: minor Milestone:
Component: HM Version: HM-5.0
Keywords: ALF Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Applies to version HM-5.0 and HM-5.0rc1.

When decoding a sequence with ALF, valgrind reports the use of uninitialised values in TComAdaptiveLoopFilter::calcVar, line 1378. No MD5 mismatches have been found yet. Encoder command line:

-c encoder_lowdelay.cfg -c RaceHorsesC.cfg -i RaceHorses_832x480_30.yuv -b ./test.bit -o ./test.yuv --FramesToBeEncoded=10 --ALF=1 --SAO=0

This is the new version of calcVar introduced as a result of G609. The issue goes away if macro G609_NEW_BA_SUB is set to 0. It's possibly due to the use of a local array with padding not properly initialised.

Setting the loop parameters to m_img_{height,width} - 3 instead of m_img_{height,width} + 3 removes the problem, but produces a different bit stream. It's unclear to me what the correct bounds should be.

Attachments (1)

valgrind_alf_G609 (4.0 KB) - added by thomasd 10 years ago.
valgrind output

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf added

Changed 10 years ago by thomasd

valgrind output

comment:2 Changed 9 years ago by ksuehring

  • Version changed from HM-5.0rc1 to HM-5.0

comment:3 Changed 9 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

A fix has been checked in for HM-5.0-dev-bugfix in r1695

comment:4 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Thomas Davies(Reporter)