Opened 13 years ago Closed 13 years ago #249 closed defect (fixed)valgrind error in ALF decoding:
Description
Applies to version HM-5.0 and HM-5.0rc1.
When decoding a sequence with ALF, valgrind reports the use of uninitialised values in TComAdaptiveLoopFilter::calcVar, line 1378. No MD5 mismatches have been found yet. Encoder command line:
-c encoder_lowdelay.cfg -c RaceHorsesC.cfg -i RaceHorses_832x480_30.yuv -b ./test.bit -o ./test.yuv --FramesToBeEncoded=10 --ALF=1 --SAO=0
This is the new version of calcVar introduced as a result of G609. The issue goes away if macro G609_NEW_BA_SUB is set to 0. It's possibly due to the use of a local array with padding not properly initialised.
Setting the loop parameters to m_img_{height,width} - 3 instead of m_img_{height,width} + 3 removes the problem, but produces a different bit stream. It's unclear to me what the correct bounds should be. Attachments (1)Change History (5)comment:1 Changed 13 years ago by DefaultCC Plugin
Changed 13 years ago by thomasdcomment:2 Changed 13 years ago by ksuehring
comment:3 Changed 13 years ago by ksuehring
A fix has been checked in for HM-5.0-dev-bugfix in r1695 comment:4 Changed 13 years ago by davidf
Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
valgrind output