Opened 8 years ago

Closed 8 years ago

#1241 closed defect (fixed)

redundant verification code

Reported by: kolya Owned by:
Priority: minor Milestone: HM-14.0
Component: HM Version: HM-13.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

on line 4456 of TEncSearch there is a verification code that contains call to obsolete encodeCoeff function. Btw, check always fails.

#if 0 check

{

m_pcEntropyCoder->resetBits();
m_pcEntropyCoder->encodeCoeff( pcCU, 0, pcCU->getDepth(0), pcCU->getWidth(0), pcCU->getHeight(0) );
const UInt uiBitsForCoeff = m_pcEntropyCoder->getNumberOfWrittenBits();
m_pcRDGoOnSbacCoder->load( m_pppcRDSbacCoder[pcCU->getDepth(0)][CI_CURR_BEST] );
if( uiBitsForCoeff != uiBits )

assert( 0 );

}

#endif

Change History (2)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Disabled code was removed in r3850

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Nikolay Shlyakhov(Reporter)