Opened 8 years ago

Closed 8 years ago

#1050 closed enhancement (fixed)

parse end_of_sub_stream_one_bit in WPP

Reported by: PhuongNguyen Owned by:
Priority: minor Milestone: HM-11.0
Component: HM Version: HM-10.0
Keywords: Cc: phuong_nguyen@…, fbossen, ksuehring, davidf, jct-vc@…

Description (last modified by ksuehring)

In WPP, the text requires to parse the syntax element end_of_sub_stream_one_bit at the end of each tile line if end_of_slice_segment_flag is equal to 0. It corresponds to the syntax element alignment_bit_equal_to_one and it must be equal to one. It seems that the parsing of end_of_sub_stream_one_bit and the check have not been done in the reference software in WPP. I suggest to add the following code in the function

Void TDecSlice::decompressSlice(TComInputBitstream** ppcSubstreams, TComPic*& rpcPic, TDecSbac* pcSbacDecoder, TDecSbac* pcSbacDecoders)
...
    cSigma.m_CbCounter=0;
#endif
#endif
    m_pcCuDecoder->decompressCU ( pcCU );
    
#if ENC_DEC_TRACE
    g_bJustDoIt = g_bEncDecTraceDisable;
#endif
    pcSbacDecoders[uiSubStrm].load(pcSbacDecoder);

    UInt uiTileRightEdgePosInCU = rpcPic->getPicSym()->getTComTile(rpcPic->getPicSym()->getTileIdxMap(iCUAddr))->getRightEdgePosInCU();
    UInt ruiBit;
    if ( (uiCol == uiTileRightEdgePosInCU) && (pcSlice->getPPS()->getEntropyCodingSyncEnabledFlag()) && !uiIsLast)
    {
      pcSbacDecoder->parseTerminatingBit(ruiBit);
      assert (ruiBit);
    }

    //Store probabilities of second LCU in line into buffer
    if ( (uiCol == uiTileLCUX+1)&& (depSliceSegmentsEnabled || (pcSlice->getPPS()->getNumSubstreams() > 1)) && (pcSlice->getPPS()->getEntropyCodingSyncEnabledFlag()) )
    {
      m_pcBufferSbacDecoders[uiTileCol].loadContexts( &pcSbacDecoders[uiSubStrm] );
    }
...

Attachments (1)

1050.patch (1.1 KB) - added by PhuongNguyen 8 years ago.
Patch for ticket #1050

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by ksuehring

  • Description modified (diff)
  • Priority changed from critical to minor

comment:3 Changed 8 years ago by ksuehring

Can you please use a patch file to make clear, what lines are changed?

Changed 8 years ago by PhuongNguyen

Patch for ticket #1050

comment:4 Changed 8 years ago by PhuongNguyen

The patch file is attached.

comment:5 Changed 8 years ago by fbossen

  • Milestone changed from HM-10.1 to HM-10.2
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3471

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • phuong_nguyen@…(Subscriber)