Opened 8 years ago

Closed 8 years ago

#993 closed enhancement (fixed)

TEncSAO m_dLambdaLuma/Chroma member variables not required

Reported by: karlsharman Owned by:
Priority: trivial Milestone: HM-10.1
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In TEncSampleAdaptiveOffset.h:59,60, m_dLambdaLuma and m_dLambdaChroma are defined.
These are written to only within TEncSampleAdaptiveOffset::SAOProcess, and never read.

Suggest removal of declarations in TEncSampleAdaptiveOffset.h
and remove the following lines of TEncSampleAdaptiveOffset.cpp:1706

#if SAO_CHROMA_LAMBDA

m_dLambdaLuma=dLambdaLuma;
m_dLambdaChroma=dLambdaChroma;

#else

m_dLambdaLuma=dLambda;
m_dLambdaChroma=dLambda;

#endif

(Identified during RExt development.)

Change History (2)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by ksuehring

  • Milestone set to HM-10.1
  • Resolution set to fixed
  • Status changed from new to closed

fixed in r3407

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)