Opened 9 years ago

Closed 9 years ago

#789 closed defect (fixed)

Chroma bit depth should be used in filtering process

Reported by: bbross Owned by:
Priority: minor Milestone: HM-8.2
Component: HM Version: HM-8.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In Void TComLoopFilter::xEdgeFilterChroma, the luma bit depth "g_uiBitIncrement+g_uiBitDepth"is used to calculate tc:

Int iBitdepthScale = (1<<(g_uiBitIncrement+g_uiBitDepth-8));
Int iIndexTC = Clip3(0, MAX_QP+DEFAULT_INTRA_TC_OFFSET, iQP + DEFAULT_INTRA_TC_OFFSET*(ucBs - 1) + (m_tcOffsetDiv2 << 1));
Int iTc = tctable_8x8[iIndexTC]*iBitdepthScale;

This should be the chroma bit depth but I cannot find a corresponding BitDepthC in HM. In SPS, only QpBdOffsetC is set.

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by davidf

  • Milestone set to HM-8.2
  • Resolution set to fixed
  • Status changed from new to closed

This specific case is fixed in r2945.

Hitherto HM has not had any complete notion of BitDepthC. This has now been implemented in HM-8.2-dev-chromabitdepth. It will be tested for compatibility with the HM-9.0 release candidates prior to merging for HM-9.0.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Reporter)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)