Opened 11 years ago

Closed 11 years ago

#70 closed defect (fixed)

ROUNDING_CONTROL_BIPRED encoding time issue

Reported by: rpanchal@… Owned by:
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: martak@…, peisongc@…, bossen@…, ken@…, rpanchal@…, hurumi@…, fbossen, ksuehring, davidf, jct-vc@…

Description

I noticed that in TComRdCost.cpp, all the functions for SAD,SSE,HAD where bRound is being passed as parameter, xClip() is being used which affects the encoding time. xClip() is redundant step.
(255+255+0)>>1 = 255 and (255+255+1)>>1 = 255.

So xClip should be removed from all these functions.

For e.g.
So in TMuC0.7.2, in TComRdCost.cpp, line 471 can be changed
from
pred = xClip( (piCur[n] + piRef[n] + bRound) >> 1 );
to
pred = (piCur[n] + piRef[n] + bRound) >> 1 ;

Results should still be bitexact.

Attachments (1)

TComRdCost.cpp (89.7 KB) - added by anonymous 11 years ago.
look for macro "ROUNDING_CONTROL_BIPRED_FIX"

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by anonymous

look for macro "ROUNDING_CONTROL_BIPRED_FIX"

comment:1 Changed 11 years ago by fbossen

How much faster will the software run with this modification?

comment:2 Changed 11 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r189 and r190

comment:3 Changed 10 years ago by davidf

  • Cc changed from martak@qualcomm.com,peisongc@qualcomm.com,bossen@docomolabs-usa.com,ken@zetacast.com,rpanchal@qualcomm.com,hurumi@gmail.com to martak@qualcomm.com, peisongc@qualcomm.com, bossen@docomolabs-usa.com, ken@zetacast.com, rpanchal@qualcomm.com, hurumi@gmail.com
  • Component set to HM

Updating component after adding WD (Text) tickets

comment:4 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:5 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • bossen@…(Subscriber)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • hurumi@…(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • ken@…(Subscriber)
  • martak@…(Subscriber)
  • peisongc@…(Subscriber)
  • rpanchal@…(Reporter, Subscriber)