Opened 11 years ago

Closed 11 years ago

#69 closed defect (fixed)

AMVRES 1/8th 6-tap DCT-IF bug

Reported by: jianle.chen@… Owned by:
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

3/8th and 5/8th position coefficients of 6-tap DCT-IF filter have bugs because of typos.

The 6 taps coefficients in TMuC 0.71 with QC_AMVRES on.

{ 11, -42, 196, 118, -36, 10 }, 3/8
{ 10, -36, 196, 118, -42, 11 },
5/8

Sum of the coefficients should be 256, while that of current coefficients is 257.

The correct coefficients should be

{ 11, -43, 196, 118, -36, 10 }, 3/8
{ 10, -36, 196, 118, -43, 11 },
5/8

Attachments (1)

patch_Ticket69.patch (442 bytes) - added by wjhan 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by wjhan

  • Priority changed from major to minor

It only affects DCT-IF 6-tap with AMVRES=1 which is not default config in testing. Thus it does not affect any existing testing results.

(TE12 is planned to test smaller number of taps in DCT-IF for low-complexity, but in low-complexity, AMVRES=0, thus there is no problem to fix this issue)

comment:2 in reply to: ↑ description Changed 11 years ago by wjhan

Replying to jianle.chen@…:

3/8th and 5/8th position coefficients of 6-tap DCT-IF filter have bugs because of typos.

The 6 taps coefficients in TMuC 0.71 with QC_AMVRES on.

{ 11, -42, 196, 118, -36, 10 }, 3/8
{ 10, -36, 196, 118, -42, 11 },
5/8

Sum of the coefficients should be 256, while that of current coefficients is 257.

The correct coefficients should be

{ 11, -43, 196, 118, -36, 10 }, 3/8
{ 10, -36, 196, 118, -43, 11 },
5/8

It seems that even corrected one has wrong symmetric filter coefficients problem. The correct coefficient should be:

{ 11, -43, 196, 118, -36, 10 }, 3/8
{ 10, -36, 118, 196, -43, 11 },
5/8

Changed 11 years ago by wjhan

comment:3 Changed 11 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r205

comment:4 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • jianle.chen@…(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Woo-Jin Han(Participant)