Opened 9 years ago

Closed 8 years ago

#599 closed defect (fixed)

Long term reference pictures (LTRPs) and MSB cycle presence

Reported by: adarsh Owned by:
Priority: minor Milestone: HM-10.1
Component: HM Version: HM-7.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

There are two locations where the MSB-cycle presence is not checked for LTRPs.

  1. The first location is in TComSlice.cpp::checkThatAllRefPicsAreAvailable(), line 984. Similar to the check in line 960, the presence of MSB cycle should be checked here.

if((rpcPic->getPicSym()->getSlice(0)->getPOC()%(1<<rpcPic->getPicSym()->getSlice(0)->getSPS()->getBitsForPOC())) == (this->getPOC() + pReferencePictureSet->getDeltaPOC(i))%(1<<rpcPic->getPicSym()->getSlice(0)->getSPS()->getBitsForPOC()) && rpcPic->getSlice(0)->isReferenced())

  1. The second occurrence is also in TComSlice.cpp, in the function setRefPicList(). In line 429, the function xGetLongTermRefPic(rcListPic, m_pcRPS->getPOC(i)) is used to fetch the long-term reference picture, but again no check is made for MSB-cycle presence.

NOTE: The attached patch file was created with respect to HM7.1 (r2479)

Attachments (1)

MSBCYCLE_BUGFIX_r2479.patch (4.2 KB) - added by adarsh 9 years ago.
Patch for MSB cycle check

Download all attachments as: .zip

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by adarsh

Patch for MSB cycle check

comment:2 Changed 8 years ago by fbossen

  • Milestone set to HM-10.1
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3391

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)