Opened 9 years ago

Closed 9 years ago

#598 closed defect (fixed)

Mismatch between WD and HM on end_of_slice_flag

Reported by: rickard Owned by: bbross
Priority: minor Milestone: D7
Component: Text Version: D7 (I1003) d4
Keywords: Cc: bbross, wjhan, jct-vc@…

Description

The conditions on when to parse the end_of_slice_flag syntax element in the case of slice granularities in 7.3.5 is incorrect.

The current condition looks like this:

       if( !( ( x0 + 1 << log2CbSize ) % ( 1 << SliceGranularity ) )  &&
           !( ( y0 + 1 << log2CbSize ) % ( 1 << SliceGranularity ) )  &&
           NumPCMBlock = = 0 ) {

One problem is that x0 + 1 << log2CbSize is ambiguous
Another problem is that (1 << SliceGranularity) is clearly incorrect
Another problem is that end_of_slice_flag should also be parsed at the end of LCUs that are "incomplete"

I believe these problems are all corrected if the current condition shown above is replaced by:

  if( (!( ( x0 + (1 << log2CbSize )) % (Log2MaxCbSize >> slice_granularity) ) || 
        ( x0 + (1 << log2CbSize ) == pic_width_in_luma_samples) ) && 
      (!( ( y0 + (1 << log2CbSize )) % (Log2MaxCbSize >> slice_granularity) ) ||
        ( y0 + (1 << log2CbSize ) == pic_height_in_luma_samples) ) && 
      NumPCMBlock = = 0 ) {

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc bbross wjhan jct-vc@… added

comment:2 Changed 9 years ago by rickard

The suggestion above is not right. The following syntax should be correct.

  if( (!( ( x0 + (1 << log2CbSize )) % ( (1 << Log2MaxCbSize) >> slice_granularity) ) || 
      ( x0 + (1 << log2CbSize ) >= pic_width_in_luma_samples)) && 
    (!( ( y0 + (1 << log2CbSize )) % ( (1 << Log2MaxCbSize) >> slice_granularity) ) ||
      ( y0 + (1 << log2CbSize ) >= pic_height_in_luma_samples)) && 
    NumPCMBlock = = 0 ) {

comment:3 Changed 9 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in JCTVC-I1003_d9.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Rickard Sjoberg(Reporter, Participant)
  • Woo-Jin Han(Subscriber)