Opened 13 years ago Closed 12 years ago #570 closed defect (fixed)Text / HM mismatch: intra_chroma_pred_mode partially bypass-coded
Description
TDecSbac::parseIntraDirLumaAng implements the binarization process for intra_chroma_pred_mode. Xhen decoding the last two bits, bypass decoding is used but the spec makes no mention of this. Since maxBinIdxCtx is 2 for intra_chroma_pred_mode, they should both be decoded using "m_pcTDecBinIf->decodeBin( uiSymbol, m_cCUChromaPredSCModel.get( 0, 0, 2 ) );" (with the same changes on the encoder side) instead. Attachments (1)Change History (6)comment:1 Changed 13 years ago by DefaultCC Plugin
comment:2 in reply to: ↑ description Changed 13 years ago by jkeicomment:3 Changed 13 years ago by bbross
I confirm that the spec is not clear on that:
When you look at the binarization you will see that there are two cases that can be divided into two known binarization schemes: TU and FL
Prefix: TU cMax = 2
Prefix: TU, cMax = 1
The tricky thing is that the mapping between bin string and value of intra_chroma_pred_mode is NOT:
Consequently it should be like:
maxBinIdxCtx:
ctxIdxTable:
ctxIdxOffset:
So we should split the binarization table row for the two cases:
The binarization process, ctx derivation and all other parts of CABAC related to this syntax element should be changed accordingly.
Any proponent who provides this fix? Changed 13 years ago by hyangcomment:4 Changed 13 years ago by hyang
Thanks for providing suggestions on the description fix of intra_chroma_pred_mode. A document containing the fix is provided in the attachment, please check it and share your comments to make it better. comment:5 Changed 12 years ago by bbross
This is fixed in JCTVC-I1003 d5 (v6). Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
According to H0326/H0475 adopted in San Jose meeting, the last two bins for intra_chroma_pred_mode are bypass coded. For clearer description, it might be better to insert a comment such as '(uses Decode Bypass)' in Table 9-39 for intra_chroma_pred_mode with binIdx 2,3 and 4 when chroma_pred_from_luma_enable_flag==true and with binIdx 1, 2,3 and 4 when chroma_pred_from_luma_enable_flag==false.
Replying to Smarter: