Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#543 closed defect (fixed)

encoder failed when the frame size was small

Reported by: peisongc Owned by:
Priority: major Milestone: HM-7.1
Component: HM Version: HM-7.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In TComAdaptiveLoopFilter.cpp (around line 752), yInterval could be zero and caused the crash. This could happen even though ALF was turned off in the encoder configuration.

Change History (4)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 10 years ago by chiayang_tsai

This bug is confirmed and only happens when the picture width or height is smaller than two LCUs. The fix is in TICKET_543_FIX macro as follows:

At Line 750 in TComAdaptiveLoopFilter.cpp,

  for(Int i = 0; i < m_img_height; i=i+4)
  {
#if TICKET_543_FIX
    yIndex = (yInterval == 0)?(3):(Clip_post( 3, i / yInterval));
#else
    yIndex = Clip_post( 3, i / yInterval);
#endif
    yIndexOffset = yIndex * 4 ;
    for(Int j = 0; j < m_img_width; j=j+4)
    {
#if TICKET_543_FIX
      xIndex = (xInterval==0)?(3):(Clip_post( 3, j / xInterval));
#else
      xIndex = Clip_post( 3, j / xInterval);
#endif
      m_varImg[i>>shiftH][j>>shiftW] = regionTable[yIndexOffset + xIndex];
    }
  }

comment:3 Changed 10 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

the patch has been applied in r2414

comment:4 Changed 10 years ago by ksuehring

  • Milestone set to HM-7.1
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chia-Yang Tsai(Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • peisongc(Reporter)