Opened 12 years ago

Closed 12 years ago

#504 closed defect (fixed)

SAO process issues

Reported by: bbross Owned by: bbross
Priority: major Milestone: D7
Component: Text Version: D6 (H1003) dI/dJ/dK
Keywords: Cc: bbross, wjhan, jct-vc@…

Description (last modified by bbross)

The following issues are present in the SAO process (8.7.2):
1.) in "8.7.2 Sample adaptive offset process"

  • the coding treeblock location ( 0, 0 ) and the largest CU location ( 0, 0 ) are redundant

2.) in " Modification process for sample adaptive offset"

  • again (rx,ry) and (x0,y0) are redundant
  • largest CUs should be CTBs
  • largest coding unit should be CTB
  • "saoWidthInCTB" should be "saoWidthInCTBs", same for Height
  • variable saoDepth not defined here

3.) in " Modification process for luma and chroma samples"

  • again xC,yC and rx, ry are redundant
  • saoTypeIdx 1-4

o edgeIdx derivation in 2. and 3. can be combined
o loop over CTB samples i.j is missing in 1.-3. (edgeIdx derivation)
o loop over component k is missing in 3. (boundary handling)
o in 2. (edgeIdx derivation), edgeIdx can only take the values 0, 2 and 4 since Sign(x) returns just 1 and -1.
o in 4. (no SAO for PCM…) edgeTable not needed

  • saoTypeIdx 5

o repeated comma after otherwise
o 1. and 2. can be combined to "1. The variable bandShift is derived as follows…"

  • saoTypeIdx 0 case can be combined with PCM/QP_Y=0 because they all do not apply SAO

4.) In general the process names/headings can be changed to be more meaningful and " Modification process for sample adaptive offset" and " Modification process for luma and chroma samples" can be combined since the first just loops over all CTBs for one color component.

Change History (4)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc bbross wjhan jct-vc@… added

comment:2 Changed 12 years ago by bbross

  • Description modified (diff)

comment:3 Changed 12 years ago by bbross

  • Milestone set to D7

comment:4 Changed 12 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in draft 7 (JCVTC-I1003_d3.doc)

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Benjamin Bross(Reporter, Owner, Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Woo-Jin Han(Subscriber)