Opened 13 years ago

Closed 13 years ago

#438 closed defect (fixed)

Text / HM mismatch for NAL unit header syntax

Reported by: Smarter Owned by:
Priority: minor Milestone: HM-6.1
Component: HM Version: HM-6.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

According to JCTVC-H1003_dK section 7.3.1, the first byte of the NAL unit is:
forbidden_zero_bit : 1 bit
nal_ref_flag : 1 bit
nal_unit_type : 6 bits

But the format written by the encoder (source/Lib/TLibEncoder/NALwrite.cpp) is:
forbidden_zero_flag : 1 bit
nal_ref_idc : 2 bits
nal_unit_type : 5 bits

Change History (6)

comment:1 Changed 13 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 13 years ago by Smarter

The output_flag written by NALwrite.cpp doesn't exist in H1003 either.

comment:3 Changed 13 years ago by ksuehring

  • Resolution set to invalid
  • Status changed from new to closed

High level syntax is currently being implemented in HM 6.1. The HM-6.1-dev branch already contains the correct syntax of the mentioned elements.

comment:4 Changed 13 years ago by Smarter

Thanks for the reply. The branch HM-6.1-dev doesn't seem to exist: ​http://hevc.kw.bbc.co.uk/trac/browser/branches . If you mean the HM-6.0-dev branch, it doesn't contain the correct syntax for the first problem I mentioned: ​http://hevc.kw.bbc.co.uk/trac/browser/branches/HM-6.0-dev/source/Lib/TLibEncoder/NALwrite.cpp

comment:5 Changed 13 years ago by ksuehring

  • Milestone set to HM-6.1
  • Resolution invalid deleted
  • Status changed from closed to reopened

Yes, I meant HM-6.0-dev.

You are right for nal_ref_flag/nal_unit_type. I thought that would have been handled with H0388. I should have double checked. This is a Torino adoption that we are missing here (JCTVC-F463).

But the output_flag has been moved to the slice header.

(PS: Could you please add your email address to the bug tracker account?)

comment:6 Changed 13 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in r2156

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • Guillaume Martres(Reporter, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)