Opened 11 years ago

Closed 11 years ago

#41 closed defect (fixed)

Some minor HHI_MRG bugs in 0.6 - already fixed in 0.7

Reported by: Heiner Kirchhoffer Owned by:
Priority: minor Milestone:
Component: HM Version:
Keywords: merge Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In TEncSearch.cpp between line 1493 and 1494, as well as between line 7039 and 7040, the following three lines need to be added:

#if HHI_MRG

m_pcEntropyCoder->encodeMergeInfo( pcCU, 0, true );

#endif

This fixes the issue, that an incorrect bitrate is estimated for RD-decisions.

In TEncEntropy.cpp between line 382 and 383, the following needs to be added:

if ( pcCU->getSlice()->isIntra() )
{

return;

}

This avoids the encoding of unwanted merge flags.

In TEncEntropy.cpp between line 900 and 901, the following needs to be added:

if( bRD )

uiAbsPartIdx = 0;

This corrects a wrong determination of merge candidates during the estimation process.

All line numbers are valid for version 0.6.

Change History (4)

comment:1 Changed 11 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r124 and r134

comment:2 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:3 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:4 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • Heiner Kirchhoffer(Reporter)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)