Opened 11 years ago

Closed 11 years ago

#40 closed defect (fixed)

Error message about input image size is wrong

Reported by: hao@… Owned by: fbossen
Priority: trivial Milestone:
Component: HM Version:
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

This error is very trivial but a bit confusing. In TAppEncCfg::xCheckParameter(),

xConfirmPara( (m_iSourceWidth % (m_uiMaxCUWidth >> (m_uiMaxCUDepth-1)))!=0, "Frame width should be multiple of double size of minimum CU size");
xConfirmPara( (m_iSourceHeight % (m_uiMaxCUHeight >> (m_uiMaxCUDepth-1)))!=0, "Frame height should be multiple of double size of minimum CU size");

should be replaced with

xConfirmPara( (m_iSourceWidth % (m_uiMaxCUWidth >> (m_uiMaxCUDepth-1)))!=0, "Frame width should be multiple of minimum CU size");
xConfirmPara( (m_iSourceHeight % (m_uiMaxCUHeight >> (m_uiMaxCUDepth-1)))!=0, "Frame height should be multiple of minimum CU size");

The current TMuC codec core allows input image sizes of odd multiple of minimum CU size and the TMuC document also does.

Change History (7)

comment:1 Changed 11 years ago by ilkoo.kim@…

I guess that current parameter confirmation of TMuC SW is only valid when QuadtreeTUFlag is equal to 1. If QuadtreeTUFlag is equal to 0 (means RQT disable), your correction is right.

comment:2 Changed 11 years ago by hao@…

No. I'm talking about both the case of QuadtreeTUFlag eqaul to 0 and 1.
There is logically no reason for TMuC SW to crash when QuadtreeTUFlag is equal to 1, both from the document and the current implementation of the codec core.
Actually, the condition ((m_iSourceWidth % (m_uiMaxCUWidth >> (m_uiMaxCUDepth-1)))!=0) does not test whether the image size is equal to multiple of double size of minimum CU or not, but tests whether it is equal to multiple of minimum CU.
(BTW, current variable definitions about CU depth, i.e., m_uiMaxCUDepth, g_uiMaxCUDepth and g_uiAddCUDepth, are very confusing...)

Anyway, TMuC v0.7 SW still work for such an image size as 136x136, and so on, at least in my environment.

comment:3 Changed 11 years ago by fbossen

  • Owner set to fbossen
  • Status changed from new to accepted

comment:4 Changed 11 years ago by fbossen

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in r167

comment:5 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:6 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:7 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Owner, Subscriber, Participant)
  • hao@…(Reporter, Participant)
  • ilkoo.kim@…(Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)