Opened 9 years ago

Closed 7 years ago

#395 closed defect (wontfix)

on the usage of iCombinedCount

Reported by: libin Owned by:
Priority: minor Milestone:
Component: HM Version: HM-6.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In HM-6.1-dev r2096, the combined merge candidates are generated according to the following process.

Int iCombinedCount = 0;
...
for (Int idx=0; idx<uiCutoff*(uiCutoff-1) && uiArrayAddr!=MRG_MAX_NUM_CANDS && iCombinedCount<5; idx++)
{

...
if (...)
{}
else
{

uiArrayAddr++;
iCombinedCount++;

}

}

As MRG_MAX_NUM_CANDS is no greater than 5 and the initial value of uiArrayAddr is no less than the initial value of iCombinedCount (0), when the condition of
uiArrayAddr!=MRG_MAX_NUM_CANDS
is true,
the condition of
iCombinedCount<5
is always true.

So I think iCombinedCount is not necessary to be there.

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 7 years ago by fbossen

  • Resolution set to wontfix
  • Status changed from new to closed

iCombinedCount variable not present in r3775

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Bin Li(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)