Opened 9 years ago

Closed 9 years ago

#327 closed defect (fixed)

AMP allowed at incorrect CU depths

Reported by: bheng Owned by:
Priority: minor Milestone:
Component: HM Version: HM-6.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

According to the binarization for part_mode, AMP partition modes are only possible when cLog2CbSize is greater than Log2MinCbSize.

The following code from HM-5.1 fails to implement this correctly.

for (Int i = 0; i < m_cSPS.getMaxCUDepth() - 1; i++)
{

m_cSPS.setAMPAcc( i, m_cSPS.getUseAMP() );

}

The getMaxCUDepth function returns the total depth, taking into account both the minimum CU and minimum TU sizes. Therefore, depending on the minimum TU size, HM can potentially allow AMP even when cLog2CbSize = Log2MinCbSize.

Also, the "-1" in the for loop is not necessary.

Attachments (1)

amp_at_smallest_cu_bug.patch (1.3 KB) - added by bheng 9 years ago.
Fix to disable AMP when cLog2CbSize == Log2MinCbSize

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by bheng

Fix to disable AMP when cLog2CbSize == Log2MinCbSize

comment:2 Changed 9 years ago by bheng

  • Version changed from HM-5.1 to HM-6.2rc1

This bug report is still valid for HM-6.2rc1. A patch is attached.

comment:3 Changed 9 years ago by ksuehring

  • Version changed from HM-6.2rc1 to HM-6.2

comment:4 Changed 9 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r2454

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Brian Heng(Reporter, Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)