Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#223 closed defect (fixed)

Wrong derivation of deblocking filter boundary for non-square transform unit

Reported by: xzheng Owned by:
Priority: minor Milestone: HM-5.0
Component: HM Version: HM-4.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

At Line 391 @ TComLoopFilter.cpp, the value of parameter "iBaseUnitIdx" should be set as "const UInt iBaseUnitIdx = uiLCUWidthInBaseUnits >> ( uiDepth + 2 );" instead of "const UInt iBaseUnitIdx = uiLCUWidthInBaseUnits >> ( uiDepth + 1 );". Considering that non-square transform block will be split to four smaller blocks with half horizontal and vertical size at this condition, the parameter "iBaseUnitIdx" is set to a wrong value at HM4.0.

This bug doesn't influence all the testing cases under common test condition. But it could cause mismatch if "QuadtreeTUMaxDepthInter" is set to 1.

Compared to HM4.0-dev-1354 version, the performance of the bug fixed version under common test condition is as follow:

Random Access HE
Y U V
Class A0.0% -0.2%-0.1%
Class B0.0% 0.0% 0.1%
Class C0.0% 0.0% 0.1%
Class D0.0% 0.0% 0.0%
Class E
Class F-0.1%-0.1%-0.1%
Overall0.0%0.0%0.0%
0.0%0.0% 0.0%
Enc Time[%] 100%
Dec Time[%] 99%



Random Access LC
Y U V
Class A0.0% 0.0% 0.0%
Class B0.0% 0.0% 0.1%
Class C0.0% 0.0% 0.0%
Class D0.0% 0.0% 0.0%
Class E
Class F0.0%-0.1%0.0%
Overall0.0%0.0%0.0%
0.0%0.0% 0.0%
Enc Time[%] 100%
Dec Time[%] 100%


Low delay B HE
Y U V
Class A
Class B0.0% -0.1%-0.2%
Class C0.0% 0.1%-0.1%
Class D0.0% 0.5% -0.1%
Class E-0.1%0.0% 0.1%
Class F-0.1%-0.1%0.0%
Overall0.0%0.1%-0.1%
0.0%-0.1%0.0%
Enc Time[%] 100%
Dec Time[%] 98%



Low delay B HE
Y U V
Class A
Class B0.0% 0.1% 0.2%
Class C0.0% 0.1%-0.2%
Class D0.0% 0.0% -0.2%
Class E-0.1%-0.1%-0.1% |
Class F 0.1% 0.3%0.0%
Overall0.0%0.1%-0.1%
0.0%-0.1%0.0%
Enc Time[%] 100%
Dec Time[%] 98%

Change History (6)

comment:1 Changed 10 years ago by ksuehring

  • Component set to HM
  • Resolution set to fixed
  • Status changed from new to closed

fixed in rev 1464 following the suggestion (HM-4.1-dev)

comment:2 Changed 10 years ago by ksuehring

  • Milestone set to HM-4.2

comment:3 Changed 9 years ago by davidf

Updating component after adding WD (Text) tickets

comment:4 Changed 9 years ago by ksuehring

  • Milestone changed from HM-4.2 to HM-5.0

change milestone to 5.0 (there will be no 4.2 release)

comment:5 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • xiaozhen(Reporter)