Opened 10 years ago

Closed 10 years ago

#160 closed defect (fixed)

(E049) SAO bug in SAO_EO_2 boundary

Reported by: chihming.fu Owned by:
Priority: minor Milestone: HM-3.1
Component: HM Version: HM-3.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Using revision r858
In TEncAdaptiveLoopFilter.cpp: 5270, the variable iSignDown2:

        iSignDown2 = xSign(pRec[iStride] - pRec[0]);

should be as follows

        iSignDown2 = xSign(pRec[iStride+1] - pRec[0]);

This bug is related to SAO_EO_2 (one type of SAO) in the LCU boundary. This modification make the meaning of SAO_EO_2 in the LCU boundary consistent with the rest of the LCU region. The BD-rate will improve about 0.01%.

Change History (6)

comment:1 Changed 10 years ago by chihming.fu

In TComAdaptiveLoopFilter.cpp: 3314, should be changed in the same way.

comment:2 Changed 10 years ago by chihming.fu

In TEncSbac.cpp: 397, the CABAC state of SAO should be update in rate-distortion optimization process. The following lines can fix this encoder-only bug.

#if MTK_SAO
  this->m_cAOFlagSCModel.copyFrom( &pSrc->m_cAOFlagSCModel);
  this->m_cAOUvlcSCModel.copyFrom( &pSrc->m_cAOUvlcSCModel);
  this->m_cAOSvlcSCModel.copyFrom( &pSrc->m_cAOSvlcSCModel);
#endif

comment:3 Changed 10 years ago by davidf

  • Resolution set to fixed
  • Status changed from new to closed

This was resolved in r864

comment:4 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:5 Changed 9 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:6 Changed 9 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chih-Ming Fu(Reporter, Participant)
  • David Flynn(Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)