Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1374 closed defect (invalid)

bit depth check condition is invalid

Reported by: eeehey Owned by:
Priority: minor Milestone:
Component: HM Version: HM-16.2
Keywords: Cc: ksuehring, davidf, karlsharman, jct-vc@…

Description

m_bitDeptherConstraint and m_chromaFormatConstraint parameter check condition is not right.

Attachments (1)

bitDepth_check_bug_fix.patch (1.0 KB) - added by eeehey 7 years ago.
bug fix patch for ticket #1374

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by DefaultCC Plugin

  • Cc ksuehring davidf karlsharman jct-vc@… added

Changed 7 years ago by eeehey

bug fix patch for ticket #1374

comment:2 Changed 7 years ago by karlsharman

  • Resolution set to invalid
  • Status changed from new to closed

This expression is correct. Please can you indicate what command line
you are using with HM ?

The bit depth of the stream must be less than or equal
to that indicated by the bit-depth of the PTL constraint flags.

eg you can have a 12-bit stream encoded using a 16-bit profile.

the maxBitDepth in that expression will be 12,
the m_bitDepthConstraint will be 16.

eg you can NOT have a 16-bit stream encoded using a 12-bit profile.

the maxBitDepth in that expression will be 16,
the m_bitDepthConstraint will be 12.

Please note that xConfirmPara confirms that the following expression
is FALSE for normal operation. If it is TRUE, then it is a failure.

This is (confusingly) opposite to how assert() operates.

So, xConfirmPara(m_bitDepthConstraint<maxBitDepth,...)
will report an error if (m_bitDepthConstraint < maxBitDepth)

comment:3 Changed 7 years ago by ksuehring

Maybe it would help to rename maxBitDepth, because that name somewhat gives (me) the impression that this would be the allowed maximum instead of being the maximum of the color plane depths. Maybe maxUsedBitDepth or maxInternalBitDepth would be better.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Yong He(Reporter)