Opened 10 years ago Closed 10 years ago #1357 closed enhancement (fixed)no-call functions
Description
TComOutputBitstream::insertAt Change History (12)comment:1 Changed 10 years ago by DefaultCC Plugin
comment:2 Changed 10 years ago by kolyacomment:3 Changed 10 years ago by kolya
One more orphaned substance
const TComMv operator + comment:4 Changed 10 years ago by ksuehring
Well, the generic question is, whether a library should remove all functionality that is currently unused, or keep some helper functions that my be useful, if people want to experiment with the software. The + operator would definitely be in category of potentially useful stuff... comment:5 Changed 10 years ago by kolya
Yes, there are some more as "dump" or "Check3" that could be used. The proposal is to mark it in a somewhat explicit way why the code should remain in a reference, if there is a need to leave it untouched. comment:6 Changed 10 years ago by ksuehring
From the above lists, I think only
TComDataCU::deriveLeftRightTopIdxAdi()
looks like it should actually be removed as there is a direct reference to directional intra, which seems not to use this neighborhood anymore. The CABAC decoder load may also not be necessary, but as with the others I see no harm in keeping it.
The problem with marking library code as unused in comments is that nobody will care about removing the marking, when the code gets used again. Usually that happens in a completely different place without even noticing the comment. comment:7 Changed 10 years ago by kolya
Okay, generally I think the approach "keeping as it is by default for reference s\w" is justified in a more reasonable way than permanent fixing, though there are technical means to force people to trace the unused things. comment:8 Changed 10 years ago by ksuehring
comment:9 Changed 10 years ago by ksuehring
comment:10 Changed 10 years ago by ksuehring
comment:11 Changed 10 years ago by ksuehring
comment:12 Changed 10 years ago by ksuehring
Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
It seems that these functions are also orphaned: