Opened 7 years ago

Closed 7 years ago

#1356 closed defect (invalid)

duplicate reading of the same syntax

Reported by: kolya Owned by:
Priority: minor Milestone: HM-16.3
Component: HM RExt Version:
Keywords: HM-dev Cc: davidf, karlsharman, jct-vc@…

Description

TDecCAVLC.cpp @ 776 has:

            READ_FLAG( uiCode, "residual_dpcm_implicit_enabled_flag");      pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_IMPLICIT, (uiCode != 0));
            READ_FLAG( uiCode, "residual_dpcm_explicit_enabled_flag");      pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_EXPLICIT, (uiCode != 0));


Change History (4)

comment:1 Changed 7 years ago by DefaultCC Plugin

  • Cc davidf karlsharman jct-vc@… added

comment:2 follow-up: Changed 7 years ago by tung.nguyen

I think it's correct, please check.

residual_dpcm_implicit_enabled_flag
residual_dpcm_explicit_enabled_flag

pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_IMPLICIT, (uiCode != 0));
pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_EXPLICIT, (uiCode != 0));

comment:3 in reply to: ↑ 2 Changed 7 years ago by kolya

Yes, this is my mistake, the input is different. Sorry about that.

Replying to tung.nguyen:

I think it's correct, please check.

residual_dpcm_implicit_enabled_flag
residual_dpcm_explicit_enabled_flag

pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_IMPLICIT, (uiCode != 0));
pcSPS->setUseResidualDPCM(RDPCM_SIGNAL_EXPLICIT, (uiCode != 0));

comment:4 Changed 7 years ago by ksuehring

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Participant, Always)
  • Nikolay Shlyakhov(Reporter, Participant)
  • Tung Nguyen(Participant)