Opened 10 years ago

Closed 10 years ago

#1257 closed defect (fixed)

Chroma subsampling directions are transposed in weighted prediction

Reported by: jackh Owned by:
Priority: minor Milestone: HM+RExt-4.2
Component: HM RExt Version: RExt-4.1 (HM-12.0)
Keywords: Cc: davidf, karlsharman, jct-vc@…


I'm surprised that this one is not on the bug tracker as it's clearly been spotted already. In HM-13.0+RExt-6.0, TComWeightPrediction.cpp, there are two pairs of lines like this:

    const Int  iHeight     = uiHeight>>csx; // TODO: RExt - fix this bug
    const Int  iWidth      = uiWidth>>csy;  // TODO: RExt - fix this bug

The shifts are transposed. The correct code would be:

    const Int  iHeight     = uiHeight>>csy;
    const Int  iWidth      = uiWidth>>csx;

This occurs in both TComWeightPrediction::addWeightBi() and Void TComWeightPrediction::addWeightUni(). I'm slightly confused as to why such a simple fix was marked as a TODO!

Change History (4)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc davidf karlsharman jct-vc@… added

comment:2 Changed 10 years ago by karlsharman

Those bugs when discovered just prior to RExt5.1 release, which was indicated to be identical in performance over RExt5.0.1 (just a code tidy and macro-removal), and hence the change was marked as a TODO. It was missed off the list for RExt5.2 (and RExt6.0) - I'll add it in a future release (thanks for the reminder).

comment:3 Changed 10 years ago by karlsharman

Fixed in r3869.

comment:4 Changed 10 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Jack Haughton(Reporter)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)