Opened 10 years ago

Closed 9 years ago

#1207 closed defect (fixed)

Bad copyToPic partition implementation in encoder

Reported by: gordon Owned by:
Priority: minor Milestone:
Component: HM Version: HM-12.0
Keywords: encoder Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

It seems as though the partition-based copyToPic does not copy the correct information -- it only copies the source side from partition 0, although the destination side (in the pic) represents the desired partition.

Looking at classD random access, the encoder results are not affected. The bad picture data are not used during encoder decisions, and are later overwritten with a CU-based copyToPic that is correct.

The attached patch fixes the source offset.

Attachments (1)

copyToPic.patch​ (8.1 KB) - added by gordon 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 10 years ago by gordon

comment:2 Changed 9 years ago by ksuehring

  • Milestone HM-12.1 deleted

comment:3 Changed 9 years ago by karlsharman

Perhaps TComDataCU::copyToPic(UChar, UInt, UInt) should be removed? It is now only called in one place for IPCM with parameters copyToPic(depth, 0, 0), which at first scan looks like it can be replaced with a call to the other version of the function: copyToPic(depth).

comment:4 Changed 9 years ago by karlsharman

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r4186 by removing the function.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • gordon clare(Reporter)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)