Opened 8 years ago

Closed 8 years ago

#1184 closed defect (fixed)

Errors in specification of inter_rdpcm_flag

Reported by: peterderivaz Owned by:
Priority: minor Milestone: RExt D5
Component: RExt text Version: RExt D4 (N1005) v3
Keywords: Cc: davidf, joel, teruhiko, jct-vc@…

Description

There seems to be some confusion with inter_rdpcm_flag and inter_rdpcm_dir_flag

  1. inter_rdpcm_flag is only read if transform_skip_flag==1, but 7.3.8.11 uses it when calculating signHidden without checking transform_skip_flag
  2. inter_rdpcm_flag and inter_rdpcm_dir_flag are written as a 2d array, but used as a 3d array
  3. In 8.5.4.2, the subprocess 8.6.5 is called without checking inter_rdpcm_flag is 1
  4. In 8.5.4.3, the subprocess 8.6.5 is called without checking inter_rdpcm_flag is 1

I believe the following changes should be made:

  1. In 7.3.8.11

residual_dpcm_inter_enabled_flag && inter_rdpcm_flag[ x0 ][ y0 ][ cIdx ]
should change to
residual_dpcm_inter_enabled_flag && transform_skip_flag[ x0 ][ y0 ][ cIdx ] && inter_rdpcm_flag[ x0 ][ y0 ][ cIdx ]

  1. In 7.3.8.11


inter_rdpcm_flag[ x0 ][ y0 ]
if( inter_rdpcm_flag[ x0 ][ y0 ] )
inter_rpdcm_dir_flag[ x0 ][ y0 ]
should change to

inter_rdpcm_flag[ x0 ][ y0 ][ cIdx ]
if( inter_rdpcm_flag[ x0 ][ y0 ][ cIdx ] )
inter_rdpcm_dir_flag[ x0 ][ y0 ][ cIdx ]

  1. In 8.5.4.2

When residual_dpcm_inter_enabled_flag is equal to 1 and transform_skip_flag[ xCb + xB0 ][ yCb + yB0 ][ 0 ] is equal to 1

should change to

When residual_dpcm_inter_enabled_flag is equal to 1 and transform_skip_flag[ xCb + xB0 ][ yCb + yB0 ][ 0 ] and inter_rdpcm_flag is equal to 1

  1. In 8.5.4.3

When residual_dpcm_inter_enabled_flag is equal to 1 and transform_skip_flag[ xCb + xBN ][ yCb + yBN ][ cIdx ] is equal to 1

should change to

When residual_dpcm_inter_enabled_flag is equal to 1 and transform_skip_flag[ xCb + xB0 ][ yCb + yBN ][ cIdx ] is equal to 1 and inter_rdpcm_flag[ xCb + xB0 ][ yCb + yBN ][ cIdx ]

(Also note that in the last item, both mentions of xBN should change to xB0)

Change History (2)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc davidf joel teruhiko jct-vc@… added

comment:2 Changed 8 years ago by davidf

  • Milestone set to RExt D5
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in O1005v1:

  • (1), by defining inference of non-present values
  • (2) missing cIdx
  • (3), (4) missing inter_rdpcm_flag checks (now explicit_rdpcm_flag)
  • (4) s/xBN/xB0/
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Joel(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Always)
  • Peter de Rivaz(Reporter)
  • Teruhiko Suzuki(Subscriber)