Opened 8 years ago

Closed 8 years ago

#1105 closed defect (invalid)

colPb location hadn't be correct

Reported by: jesanluo Owned by: David Flynn
Priority: minor Milestone: HM-11.0
Component: HM Version: HM-10.0
Keywords: colPb Cc: Frank, Bossen, fbossen, ksuehring, davidf, jct-vc@…

Description

accodding to 8.5.3.2.7 of JCTVC_L1003_V34 , the location of colPb need align with 16, but this is not corrected on HM-10

Change History (4)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by ksuehring

  • Milestone changed from HM-10.1 to HM-11.0

Can you be more precise in terms of which section of the code you are referring to?

Does that apply to HM 11 (which has just been tagged)?

comment:3 Changed 8 years ago by jesanluo

Sorry about my rough description;
This defect is still exist at HM11
according to <8.5.3.2.7 Derivation process for temporal luma motion vector prediction> of JCTVC_L1003_V34

"-The variable colPb specifies the luma prediction block covering the modified location given by ( ( xColBr >> 4 ) << 4, ( yColBr >> 4 ) << 4 ) inside the collocated picture specified by colPic."
"-The luma location ( xColPb, yColPb ) is set equal to the top-left sample of the collocated luma prediction block specified by colPb relative to the top-left luma sample of the collocated picture specified by colPic."

the code line 2580 of getInterMergeCandidates in TComDataCu.cpp we need change to like this

"uiAbsPartAddr = g_auiRasterToZscan[ (uiAbsPartIdxTmp + uiNumPartInCUWidth + 1) >> 2 ];"
"uiLCUIdx = getAddr();"

because g_auiRasterToZscan descrip 4*4 block and there need to 16*16 block left top location

the same change need apply to line 3376 , line 2925 , line 2916 and line 2589

line 2585 and line 2921 can be deleted

thank you!

comment:4 Changed 8 years ago by fbossen

  • Resolution set to invalid
  • Status changed from new to closed

I suggest you look at TComDataCU::compressMV() which is the function taking care of the MV subsampling

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • luo ning(Reporter, Participant)