Opened 11 years ago

Closed 11 years ago

#11 closed defect (fixed)

r19 doesn't build with PLANAR_INTRA 1 and no deblocking filter

Reported by: davidf Owned by: davidf
Priority: minor Milestone:
Component: HM Version:
Keywords: Cc: arild.fuldseth@…, fbossen, ksuehring, davidf, jct-vc@…

Description (last modified by davidf)

Build fails if using:

#define ANG_INTRA 0
#define PLANAR_INTRA 1
#define TENTM_DEBLOCKING_FILTER 0
#define HHI_DEBLOCKING_FILTER 0

Build log:

source/Lib/TLibCommon/TComLoopFilter.cpp: In member function 'Void TComLoopFilter::xDeblockCU(TComDataCU*, UInt, UInt)':
source/Lib/TLibCommon/TComLoopFilter.cpp:198:64: error: 'xEdgeFilterPlanarIntra' was not declared in this scope
source/Lib/TLibCommon/TComLoopFilter.cpp:211:64: error: 'xEdgeFilterPlanarIntra' was not declared in this scope

Attachments (1)

tmuc-issue11+fix.patch (2.1 KB) - added by davidf 11 years ago.
Possible fix by adjusting macro guards

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by davidf

  • Description modified (diff)
  • Owner set to davidf
  • Status changed from new to accepted

comment:2 Changed 11 years ago by davidf

  • Description modified (diff)

It looks like the following is occuring in source/Lib/TLibCommon/TComLoopFilter.h:

5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  72) #if HHI_DEBLOCKING_FILTER || TENTM_DEBLOCKING_FILTER
...
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  87) #if PLANAR_INTRA
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  88)   Void xPelFilterPlanarIntra      ( Pel* piSrc, Int iOffset, Int iBlkSize );
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  89)   Void xEdgeFilterPlanarIntra     ( TComDataCU* pcCU, UInt uiAbsZorderIdx, Int iDir );
5b41c967 (Arild Fuldseth 2010-06-24 14:02:43 +0000  90) #endif
As this is from your integration, please can you confirm that the #PLANAR_INTRA block should be moved outside the "HHI_DEBLOCKING_FILTER
TENTM_DEBLOCKING_FILTER" prepr ocessor guard.

Changed 11 years ago by davidf

Possible fix by adjusting macro guards

comment:3 Changed 11 years ago by davidf

The above attachment appears to allow the build to proceed. I have not tested to see if the results are sensible yet.

comment:4 Changed 11 years ago by davidf

  • Resolution set to fixed
  • Status changed from accepted to closed

This has been applied as r55

comment:5 Changed 10 years ago by davidf

  • Component set to HM

Updating component after adding WD (Text) tickets

comment:6 Changed 10 years ago by davidf

  • Cc fbossen ksuehring davidf added

comment:7 Changed 10 years ago by davidf

  • Cc jct-vc@… added
Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • arild.fuldseth@…(Subscriber)
  • David Flynn(Reporter, Owner, Subscriber, Participant)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)