Opened 8 years ago

Closed 8 years ago

#1026 closed enhancement (fixed)

TComTrQuant::xGetICRate is deprecated.

Reported by: karlsharman Owned by:
Priority: minor Milestone: HM-12.1
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The three references to xGetICRate in RDOQ should be changed
to xGetICRateCost (all parameters are the same).

xGetICRate uses the old scheme of Golomb-Rice coding but appears to function similarly to xGetICRateCost that uses the updated scheme.

(xGetICRateCost also accounts for cost of sign bit, but this will not cause a problem where xGetICRate is concerned, since those places consider relative differences.)

Attachments (2)

fix1026.patch (1.8 KB) - added by wangj 8 years ago.
patch-ticket-1026.txt (9.2 KB) - added by karlsharman 8 years ago.
Patch of 1026 and unification of cost functions

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by wangj

The references to xGetICRate in RDOQ should not be changed to xGetICRateCost because of the following differences between the two functions:

  1. xGetICRate returns a rate (integer), whereas xGetICRateCost returns a cost (double), which is lambda * rate.
  2. The input 'uiAbsLevel' for xGetICRate can be either zero or non-zero, whereas xGetICRateCost assumes a non-zero 'uiAbsLevel' (the sign cost is always added).

The Golomb-Rice code in xGetICRate should be made the same as that in xGetICRateCost. A patch is provided to fix the problem.

Changed 8 years ago by wangj

Changed 8 years ago by karlsharman

Patch of 1026 and unification of cost functions

comment:3 Changed 8 years ago by fbossen

  • Milestone set to HM-12.1
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3544

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • Jing Wang(Participant)
  • Karl Sharman(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)