Opened 10 years ago

Closed 10 years ago

#43 closed defect (fixed)

decoder ignores sps_ext_or_max_sub_layers_minus1

Reported by: johnnyVidyo Owned by: Vadim
Priority: major Milestone: SHM-7.0
Component: SHM software Version: SHM-6.1
Keywords: SPS Cc: Vadim, jct-vc@…

Description

According to F.7.4.3.2.1, the SPS element sps_ext_or_max_sub_layers_minus1 should be used to infer the value of element sps_max_sub_layers_minus1 when sps_max_sub_layers_minus1 is absent. However, after the decoder parses sps_ext_or_max_sub_layers_minus1, the expected inference does not happen and the value is not interpreted properly.

Element sps_ext_or_max_sub_layers_minus1 is parsed as follows:

READ_CODE(3, uiCode, "sps_ext_or_max_sub_layers_minus1");     uiTmp = uiCode;

Afterward, the value of uiCode is not used for anything, and the value of uiTmp is used to set variable bMultiLayerExtSpsFlag. There should be code like this to properly interpret the element:

if (uiCode != 7)
   pcSPS->setMaxTLayers(uiCode + 1);

Change history (2)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc Vadim jct-vc@… added

comment:2 Changed 10 years ago by Vadim

  • Resolution set to fixed
  • Status changed from new to closed

I believe it was already fixed with rev 923 and the following code:

READ_CODE( 3,  uiCode, "sps_ext_or_max_sub_layers_minus1" );     uiTmp = uiCode;
if(!( pcSPS->getLayerId() != 0 && uiTmp == 7 ))
{
  pcSPS->setMaxTLayers(uiTmp+1);
}

Please reopen the ticket if the problem still exists.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Always)
  • jct-vc@…(Subscriber)
  • johnnyVidyo(Reporter)
  • Karsten Suehring(Always)
  • Vadim Seregin(Owner, Subscriber, Participant)