Opened 9 years ago

Closed 9 years ago

#42 closed defect (fixed)

sps_scaling_list_ref_layer_id should be u(6)

Reported by: johnnyVidyo Owned by: Vadim
Priority: major Milestone: SHM-7.0
Component: SHM software Version: SHM-6.1
Keywords: SPS Cc: Vadim, jct-vc@…

Description

In the SPS (F.7.3.2.2.1), the element sps_scaling_list_ref_layer_id is listed as a 6-bit value, u(6).

The SHM treats this element as a variable length code.
In TDecCAVLC.cpp, the element is parsed as follows:

READ_UVLC(uiCode, "sps_scaling_list_ref_layer_id");

In TEncCavlc.cpp, the element is written as follows:

WRITE_UVLC(pcSPS->getScalingListRefLayerId(), "sps_scaling_list_ref_layer_id");

Attachments (1)

fix42.patch​ (2.8 KB) - added by o.nakagami 9 years ago.

Download all attachments as: .zip

Change history (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc Vadim jct-vc@… added

comment:2 Changed 9 years ago by johnnyVidyo

The same problem affects the PPS. Section F.7.3.2.3.3 specifies a u(6) for element pps_scaling_list_ref_layer_id, but the SHM parses and writes the value as a variable length code.

Changed 9 years ago by o.nakagami

comment:3 Changed 9 years ago by o.nakagami

Thank you for pointing this out. A suggested fix is attached. Please check.

comment:4 Changed 9 years ago by Vadim

  • Resolution set to fixed
  • Status changed from new to closed

fixed with rev 937 as provided in the patch

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Always)
  • jct-vc@…(Subscriber)
  • johnnyVidyo(Reporter, Participant)
  • Karsten Suehring(Always)
  • Ohji Nakagami(Participant)
  • Vadim Seregin(Owner, Subscriber, Participant)