Opened 8 years ago

Closed 7 years ago

#953 closed defect (fixed)

Best motion not stored during uni-directional search in list1 in certain case

Reported by: hyang Owned by:
Priority: minor Milestone: HM-16.3
Component: HM Version: HM-9.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In case the same picture inserted into both list0 and list1 at the same position, the best motion from list1 search may not be stored correctly. This bug dose not show up in the current HM configuration.

It is found under the context of ref_idx approach implementation in SHVC software SMuC0.1.1. Detailed description of the bug and the fix can be found in document JCTVC-L0167.

Attachments (1)

TEncSearch.cpp.patch (859 bytes) - added by hyang 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 8 years ago by libin

JCTVC-L0034 is a relevant proposal, which proposes to do the cleanup work of the motion estimation process, mainly by removing the left over lines related to combined list.

comment:3 Changed 8 years ago by ksuehring

Is there a patch available?

Changed 8 years ago by hyang

comment:4 Changed 8 years ago by hyang

Patch attached.

comment:5 Changed 7 years ago by karlsharman

Is there an updated patch for this? Is this still a problem?
As this was highlighted in SHVC, how does the SHVC version of
this function differ from HM?

The code highlighted in the patch was effectively removed
following adoption of L0034 "Cleanup for motion estimation process in HM"
in revision r3398 of HM-10.0-dev.

comment:6 Changed 7 years ago by Vadim

The fix was implemented into SHM with rev 19, basically it is leftovers after removing the combined list.

comment:7 Changed 7 years ago by karlsharman

Thanks for the pointers.

It looks like that fix was also subsequently removed from SHM when L0034 was patched into SHM:

SHM rev 19 added the patch to line 3503.
This became line 3479 of SHM rev. 189.
In SHM rev. 189, the L0034 macro is removing line 3479.
The code is finally removed in SHM rev. 310

So I believe I can assume that this bug was fixed in r3398.

comment:8 Changed 7 years ago by karlsharman

  • Milestone set to HM-16.3
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3398 due to changes from JCTVC-L0034.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Bin Li(Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • haitao(Reporter, Participant)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Vadim Seregin(Participant)