Opened 9 years ago

Closed 9 years ago

#922 closed defect (fixed)

RDOQ missing support for chroma QP offsets

Reported by: lkerofsky Owned by:
Priority: minor Milestone: HM-9.2
Component: HM Version: HM-9.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The chroma distortion weighting in RDOQ does not account for chroma QP offsets. A patch is attached which uses separate weights for Cb and Cr, computes the weights using appropriate QP offsets, includes the chroma format in RDOQ function calls to select the appropriate weight.

Attachments (2)

RDOQuant.patch (13.0 KB) - added by lkerofsky 9 years ago.
RDOQuant_r1.patch (13.1 KB) - added by lkerofsky 9 years ago.
modification to patch to reflect comments

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by lkerofsky

comment:2 Changed 9 years ago by fbossen

The patch seems to have some issues:

  • In the last modification in TEncSearch.cpp, uiDistortionBest is replaced by uiDistortion. Copy-paste gone wrong?
  • "i" prefix should be avoided in names of variable introduced in TEncSlice.cpp
  • Int type should be used instead of int in TComRdCost.cpp

Changed 9 years ago by lkerofsky

modification to patch to reflect comments

comment:3 Changed 9 years ago by fbossen

  • Milestone set to HM-9.2
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3164

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Louis Kerofsky(Reporter)