Opened 9 years ago

Closed 9 years ago

#913 closed defect (fixed)

Wrong pointer to SPS

Reported by: adarsh Owned by:
Priority: minor Milestone: HM-9.2
Component: HM Version: HM-9.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

While parsing SEI messages, the SPS parameters to be updated are updated using m_SEIs->m_pSPS that is initialized as

m_SEIs->m_pSPS = m_parameterSetManagerDecoder.getSPS(0);

The allocation should rather be

m_SEIs->m_pSPS = m_parameterSetManagerDecoder.getPrefetchedSPS(0);

because only that fetches the SPS from the correct buffer. Now, the use of "0" as the ID for the SPS to be accessed is another error (works only as long as the only SPS id used is 0), but that fix would need much more work.

Change History (4)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by adarsh

The mentioned line of code occurs in TDecTop::xDecodeSEI() in TDecTop.cpp.

comment:3 Changed 9 years ago by ksuehring

Well, that still is wrong, because it assumes there is a SPS with ID 0. I think we now decided that the active parameter sets SEI is supposed to activate an SPS. I think that part of K0120 is still missing.

comment:4 Changed 9 years ago by ksuehring

  • Milestone set to HM-9.2
  • Resolution set to fixed
  • Status changed from new to closed

fixed in r3226. More work is still necessary to support proper parameter set activation.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter, Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)