Opened 9 years ago

Closed 9 years ago

#845 closed defect (fixed)

[SAO] filterPicture(), entering SAOProcess() condition flaw

Reported by: conrad.ho Owned by:
Priority: minor Milestone: HM-9.2
Component: HM Version: HM-9.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The spec allows each slice with different slice_sao_luma_flag/slice_sao_chroma_flag value. However, in the function filterPicture(), it only checks the flags of the first slice to determine the whole frame needs SAO process or not.

pcSlice = rpcPic->getSlice(0);
...
if( pcSlice->getSPS()->getUseSAO() )
{

if(pcSlice->getSaoEnabledFlag()
pcSlice->getSaoEnabledFlagChroma())

{

...
m_pcSAO->SAOProcess(rpcPic, saoParam);
...

}

}

This contradicts the spec when multiple slices, 1st slice is without SAO, but some other slice(s) is with SAO.

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by fbossen

  • Milestone changed from HM-9.1 to HM-9.2
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3122

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Conrad Ho(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)