Opened 9 years ago

Closed 9 years ago

#785 closed defect (fixed)

Error in de-blocking

Reported by: adarsh Owned by:
Priority: minor Milestone: HM-9.1
Component: HM Version: HM-8.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

There looks like an error in the deblocking code. Since it is identical in the encoder and decoder, it doesn't show up in common test conditions. The following line of code (and two other similar occurences) in TComLoopFilter::xGetBoundaryStrengthSingle() is erroneous.

iRefIdx = pcCUP->getCUMvField(REF_PIC_LIST_0)->getRefIdx(uiPartP);
piRefP0 = (iRefIdx < 0) ? NULL : (Int*) pcSlice->getRefPic(REF_PIC_LIST_0, iRefIdx);

pcSlice is the slice containing current CU (and partition Q), while pcCUP (partition P) could be from another slice; the second line should therefore be

iRefIdx = pcCUP->getCUMvField(REF_PIC_LIST_0)->getRefIdx(uiPartP);
piRefP0 = (iRefIdx < 0) ? NULL : (Int*) pcCUP->getSlice()->getRefPic(REF_PIC_LIST_0, iRefIdx);

Similar changes for similar occurences (all in the same function) as above. Attached patch solves this issue.

Attachments (1)

Deblocking_partitionP_slice_bugfix_785.patch (1.9 KB) - added by adarsh 9 years ago.
Deblocking: slice containing partition P_bugfix

Download all attachments as: .zip

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by adarsh

Deblocking: slice containing partition P_bugfix

comment:2 Changed 9 years ago by ksuehring

  • Milestone set to HM-9.1
  • Resolution set to fixed
  • Status changed from new to closed

fixed in r3084

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)