Opened 12 years ago

Closed 12 years ago

#755 closed defect (fixed)

Potential Bug in "TEncSearch,cpp"

Reported by: kazushi Owned by:
Priority: minor Milestone: HM-8.1
Component: HM Version: HM-8.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

1555 if(uiSingleCbfU == 0)
1556 {
1557 pcCU ->setTransformSkipSubParts ( 0, TEXT_CHROMA_U, uiAbsPartIdx, uiFullDepth );
1558 bestModeIdUV[0] = 0;
1559 }
1560 if(uiSingleCbfV == 0)
1561 {
1562 pcCU ->setTransformSkipSubParts ( 0, TEXT_CHROMA_V, uiAbsPartIdx, uiFullDepth );
1563 bestModeIdUV[0] = 0;
1564 }
1565 }

Should Line 1563 be as follows?

1563 bestModeIdUV[1] = 0;

Attachments (1)

TEncSearch.cpp.patch​ (427 bytes) - added by xipe 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 12 years ago by xipe

comment:2 in reply to: ↑ description Changed 12 years ago by xipe

I agree that Line 1563 is incorrect. I have created a patch as attached.

comment:3 Changed 12 years ago by ksuehring

Did you see any effect on RD-performance?

comment:4 Changed 12 years ago by xipe

It will not affect the RD-performance. In Intra-frame coding, the mode decisions for Luma and Chroma are separately conducted, i.e. bLumaOnly is true in xRecurIntraCodingQT. Therefore, this block of code will not run.

comment:5 Changed 12 years ago by ksuehring

  • Milestone set to HM-8.1
  • Resolution set to fixed
  • Status changed from new to closed

fixed in r2773

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Kazushi Sato(Reporter)