Opened 9 years ago

Closed 9 years ago

#750 closed defect (fixed)

Temporal_id is incorrect when TARGET_DECLAYERID_SET is 1

Reported by: jonatan Owned by:
Priority: minor Milestone: HM-8.1
Component: HM Version: HM-8.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

When TARGET_DECLAYERID_SET is 1 (which it is by default in HM-8.0) the temporal_id is set to 0 in the NAL unit header (on the encoder side) for all pictures regardless of the value of temporal_id in the config file.

Attachments (1)

TargetDecLayer_NALInit_fix.patch (3.9 KB) - added by obici 9 years ago.
Patch for the fix

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by obici

Patch for the fix

comment:2 in reply to: ↑ description Changed 9 years ago by obici

Replying to jonatan:

When TARGET_DECLAYERID_SET is 1 (which it is by default in HM-8.0) the temporal_id is set to 0 in the NAL unit header (on the encoder side) for all pictures regardless of the value of temporal_id in the config file.

I believe the attached patch would fix the problem.

comment:3 Changed 9 years ago by ksuehring

  • Milestone set to HM-8.1
  • Resolution set to fixed
  • Status changed from new to closed

I have committed the actual fix in r2775 and a modified version of the variable renaming (according to style guide rules) in r2776.

Please try to keep fixes separate from refactoring (i.e. renaming of variables)

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • Jonatan Samuelsson(Reporter)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)