Opened 9 years ago

Closed 9 years ago

#746 closed defect (fixed)

removal of HHI_AMP_OFF macro and extraneous syntax in SPS

Reported by: dthoang Owned by:
Priority: major Milestone:
Component: HM Version: HM-8.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

In HM-8.0, the HHI_AMP_OFF macro is undefined. The only place this macro is used is in xInitSPS() in TEncTop.cpp.

#if HHI_AMVP_OFF

for ( i = 0; i < g_uiMaxCUDepth; i++ )
{

m_cSPS.setAMVPMode( i, AM_NONE );

}

#else

for ( i = 0; i < g_uiMaxCUDepth; i++ )
{

m_cSPS.setAMVPMode( i, AM_EXPL );

}

#endif

These extraneous AMVPMode flags are written in the SPS in conflict with the DIS text.

It is strongly suggested to remove the AMVPMode syntax elements and also remove AMVPMode flags as clean up.

I am attaching a suggested patch.

Attachments (1)

cleanup.patch (12.4 KB) - added by dthoang 9 years ago.
diff patch file for suggested fix

Download all attachments as: .zip

Change History (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 9 years ago by dthoang

diff patch file for suggested fix

comment:2 Changed 9 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed

I have added the cleanup with a guard macro similar to slice header cleanups that we also have in HM-8.0-dev. These macros should be removed in HM 8.2.

Committed in r2757

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Dzung Hoang(Reporter)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)