Opened 12 years ago

Closed 12 years ago

#651 closed defect (fixed)

Mismatch with text: cu_transquant_bypass_flag is decoded for PCM blocks

Reported by: pieterkapsenberg Owned by:
Priority: minor Milestone: HM-8.0
Component: HM Version: HM-7.1
Keywords: pcm lossless Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The transquant_bypass flag, when enabled in the PPS, is decoded even for PCM blocks.

in TDecCu::xDecodeCU

  if (pcCU->getSlice()->getPPS()->getTransquantBypassEnableFlag())
  {
    m_pcEntropyDecoder->decodeCUTransquantBypassFlag( pcCU, uiAbsPartIdx, uiDepth );
  }

I think should be changed to:

  if (pcCU->getSlice()->getPPS()->getTransquantBypassEnableFlag() && pcCU->getNumSucIPCM() == 0 )
  {
    m_pcEntropyDecoder->decodeCUTransquantBypassFlag( pcCU, uiAbsPartIdx, uiDepth );
  }

Attachments (1)

20120806-bug-fix.patch​ (1.6 KB) - added by kchono 12 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 12 years ago by kchono

comment:2 Changed 12 years ago by kchono

I think that the suggested fix is correct. And also, I think that we need to fix the encoder side as well (disable sending cu_transquant_bypass_flags at pcm blocks). The attachment is a patch to fix the issues of HM-8.0rc1.

comment:3 Changed 12 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r2698

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Keiichi Chono(Participant)
  • Pieter Kapsenberg(Reporter)