Opened 9 years ago

Closed 9 years ago

#644 closed defect (fixed)

Intialization of variables in TComPicSym

Reported by: adarsh Owned by:
Priority: minor Milestone: HM-8.1
Component: HM Version: HM-7.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

All the member variables of class TComPicSym are not initialized to 0/NULL/appropriate value; only m_uiNumAllocatedSlice is done so. This could be a create issues if TComPicSym::destroy() is called without initialization.

Possible solution: Replace existing constructor in TComPicSym.h by the following in TComPicSym.cpp

TComPicSym::TComPicSym()
: m_uiWidthInCU (0)
, m_uiHeightInCU (0)
, m_uiMaxCUWidth (0)
, m_uiMaxCUHeight (0)
, m_uiMinCUWidth (0)
, m_uiMinCUHeight (0)

, m_uhTotalDepth (0)
, m_uiNumPartitions (0)
, m_uiNumPartInWidth (0)
, m_uiNumPartInHeight(0)
, m_uiNumCUsInFrame (0)

, m_apcTComSlice (NULL)
, m_uiNumAllocatedSlice (0)
, m_apcTComDataCU (NULL)

, m_iTileBoundaryIndependenceIdr (0)
, m_iNumColumnsMinus1 (0)
, m_iNumRowsMinus1 (0)
, m_apcTComTile (NULL)
, m_puiCUOrderMap (NULL)
, m_puiTileIdxMap (NULL)
, m_puiInverseCUOrderMap (NULL)
{}

Change History (2)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

comment:2 Changed 9 years ago by ksuehring

  • Milestone set to HM-8.1
  • Resolution set to fixed
  • Status changed from new to closed

this has been added in r2725

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)