Opened 12 years ago Closed 12 years ago #630 closed defect (fixed)transform_tree xBase and yBase should be previous x0C and y0C
Description
In the WD, transform_tree is recursively called with: transform_tree( x0L, y0L, x0C, y0C, x0L, y0L, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 0 ) transform_tree( x1L, y1L, x1C, y1C, x0L, y0L, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 1 ) transform_tree( x2L, y2L, x2C, y2C, x0L, y0L, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 2 ) transform_tree( x3L, y3L, x3C, y3C, x0L, y0L, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 3 )
Which mean that in the called functions, we have xBase = x0L and yBase = y0L, but these function arguments are used for chroma elements, like cbf_cb[ xBase ][ yBase ][ trafoDepth − 1 ], so we should have xBase = x0C and yBase = y0C, and the recursive calls should be changed to: transform_tree( x0L, y0L, x0C, y0C, x0C, y0C, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 0 ) transform_tree( x1L, y1L, x1C, y1C, x0C, y0C, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 1 ) transform_tree( x2L, y2L, x2C, y2C, x0C, y0C, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 2 ) transform_tree( x3L, y3L, x3C, y3C, x0C, y0C, log2CbSize, log2TrafoWidth − 1, log2TrafoHeight − 1, trafoDepth + 1, 3 ) Change History (5)comment:1 Changed 12 years ago by DefaultCC Plugin
comment:2 Changed 12 years ago by Smarter
comment:3 Changed 12 years ago by bbrosscomment:4 Changed 12 years ago by bbross
comment:5 Changed 12 years ago by bbross
Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
I confirm the issue and the fix. The issue would be solved by removing NSRQT from draft text.