Opened 12 years ago

Closed 12 years ago

#623 closed defect (fixed)

LCU based SAO parameters still stored in APS structure

Reported by: ksuehring Owned by:
Priority: minor Milestone: HM-8.0
Component: HM Version: HM-7.1
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…


After the removal of that SAO parameters from the APS these are still stored in structures inside the TComAPS class. With the C-Style memory allocation from outside this creates memory leaks at the decoder because the APS contents are never disposed. Especially the parameter set manager cannot destroy these parameters because it would need a pointer to the SAO class to call the proper memory disposal methods.

All parameter storage classes should be able to destruct properly without needing pointers to function classes.

Attachments (1)

TComSampleAdaptiveOffset.cpp (38.6 KB) - added by ywhe 12 years ago.
fixed the memory leak for SAO data st.ored in APS. The fixed fucntion is SAOParam::~SAOParam()

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 12 years ago by ywhe

fixed the memory leak for SAO data st.ored in APS. The fixed fucntion is SAOParam::~SAOParam()

comment:2 Changed 12 years ago by chiayang_tsai

The adopted J0047 has solved this problem very clean (not only fix ~SAOParam()). This ticket will be fixed when J0047 is committed into HM.

comment:3 Changed 12 years ago by ksuehring

  • Milestone set to HM-8.0
  • Resolution set to fixed
  • Status changed from new to closed

Frank has taken care of this when disabling the APS in HM 8.0

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Chia-Yang Tsai(Participant)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Reporter, Subscriber, Participant, Always)