Weighted prediction process needs major revision
The following issues are present in the WP process 8.5.2.2.3:
- The input "bit-depth of the chroma component, bitDepth" is wrong for luma invocation.
- Variables shift1, shift2, offset1 and offset2 are derived in 8.5.2.2.3 but used in 8.5.2.2.3.1 Default weighted sample prediction process
- The whole process is inconsistent w.r.t. luma/chroma in 8.5.2.2.3.2 Weighted sample prediction process:
- there is a "with H being replaced by Y for luma samples and by C for chroma samples". How do we know that is is luma or chroma?
- For the derivation of logWDC, o0C, o1C, and w0C, w1C, "If C is equal to L"... Where comes C from?
- Why is BitDepthC and BitDepthY used in this derivation although corresponding bitDepth is input parameter and set to the global variables when invoked?
- Wouldn't it be better to pass a cIdx and derive variables depending on that variable?
- logWDC should be log2WDC and derivation of these variable should be moved at the beginning (see #433)
- Invocation of the WP process for chroma should be split into two paragraphs as it is done for other processes.
- Minor improvement: Since it is not used somewhere else, "the same as specified in sub clause 8.5.2.2.3" should be replaced by the actual inputs and outputs. (see #433)
Who is going to fix this?
Change History (2)
Changed 12 years ago by DefaultCC Plugin
-
Cc
bbross wjhan jct-vc@… added
-
Resolution
set to fixed
-
Status
changed from new to closed
|
Fixed in JCTVC-I1003_d8.