Opened 12 years ago

Closed 12 years ago

#595 closed defect (fixed)

14-bit offset issues

Reported by: pandrivon Owned by:
Priority: major Milestone:
Component: HM Version: HM-7.0
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

Offset issues w.r.t. 14-bit:

in HM7.0, TComWeightPrediction::addWeightBi()and

TComWeightPrediction::addWeightUni()appearing three times (luma and chroma) for each.
{
…

Int shiftNum = IF_INTERNAL_PREC - ( g_uiBitDepth + g_uiBitIncrement );
Int shift = wp0[0].shift + shiftNum; may be null
Int round = (1<<(shift-1)) * bRound; beget negative shift here!'

…
}
and
in HM7.0 TComInterpolationFilter::filterCopy()
{
…
Int shift = IF_INTERNAL_PREC - ( g_uiBitDepth + g_uiBitIncrement ); may be null
Short offset = IF_INTERNAL_OFFS + (1 << (shift - 1)); beget negative shift here!'
…
}

Lightweight solution is to set round and offset to 0 when bit-depth = 14...
Same issue in Draft 7 d4 (Cf. ​Ticket #594)
Any thoughts?

Attachments (1)

14-bit_offset_issue_WP_IF.patch​ (2.5 KB) - added by pandrivon 12 years ago.
Straitghtforward patch for offset issue (14-bit) in IF and WP

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 12 years ago by pandrivon

Straitghtforward patch for offset issue (14-bit) in IF and WP

comment:2 Changed 12 years ago by pandrivon

Just provided a straightforward patch as a suggestion (on top of HM7.1rc1)

comment:3 Changed 12 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r2482

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Pierre Andrivon(Reporter, Participant)